{{ message }}
feat: enable resetting accent color#48274
Merged
Merged
Conversation
codebytere
added
semver/minor
codebytere
force-pushed
the
reset-accent-color
branch
from
344fbcf to
70d558f
Compare
codebytere
force-pushed
the
reset-accent-color
branch
from
70d558f to
6e6509a
Compare
Member
erickzhao
reviewed
Sep 18, 2025
codebytere
force-pushed
the
reset-accent-color
branch
2 times, most recently
from
908ee22 to
6fd43ca
Compare
codebytere
force-pushed
the
reset-accent-color
branch
from
6fd43ca to
5e69d8b
Compare
erickzhao
reviewed
Oct 16, 2025
itsananderson
approved these changes
Oct 16, 2025
itsananderson
left a comment
itsananderson
left a comment
Member
There was a problem hiding this comment.
Couple comments to try to make the examples super specific, but otherwise API LGTM
codebytere
force-pushed
the
reset-accent-color
branch
from
9f79c73 to
ec76729
Compare
erickzhao
reviewed
Oct 17, 2025
jkleinsc
approved these changes
Oct 21, 2025
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "37-x-y" cleanly; |
trop
Bot
removed
the
target/37-x-y
Contributor
|
I was unable to backport this PR to "39-x-y" cleanly; |
trop
Bot
added
needs-manual-bp/37-x-y
and removed
target/39-x-y
Contributor
|
I was unable to backport this PR to "38-x-y" cleanly; |
trop
Bot
added
needs-manual-bp/39-x-y
needs-manual-bp/38-x-y
and removed
target/38-x-y
TheCommieAxolotl
pushed a commit
to TheCommieAxolotl/electron
that referenced
this pull request
Nov 2, 2025
Contributor
|
@codebytere can this be backported at least to Electron 39? |
Contributor
|
@codebytere has manually backported this PR to "39-x-y", please check out #48852 |
Contributor
trop
Bot
added
in-flight/38-x-y
merged/39-x-y
nilayarya
pushed a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #48232.
Enables resetting accent color to follow system accent settings if a previous color has been set.
Checklist
npm testpassesRelease Notes
Notes: Enables resetting accent color to follow system accent settings if a previous color has been set via
window.setAccentColor(null).