{{ message }}
feat: add about panel customization on Windows#19420
Merged
Merged
Conversation
4fbbc47 to
d5fbbec
Compare
3 tasks
Member
Member
Author
@codebytere yep! I was waiting for that one to get merged to avoid having to re-implement all the business logic available in |
63ae694 to
49ad7d5
Compare
65cd83a to
752cddb
Compare
deermichel
suggested changes
Aug 1, 2019
4 tasks
Member
Author
|
Update: added default values for |
deermichel
approved these changes
Aug 12, 2019
deermichel
left a comment
Contributor
There was a problem hiding this comment.
Lgtm & works for me.
Are you aware that the dialog's title will be derived from app.name?
Member
Author
|
MarshallOfSound
approved these changes
Aug 12, 2019
codebytere
approved these changes
Aug 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of Change
Closes #15591. Adds support for
showAboutPanel()andsetAboutPanelOptions()on Windows.Windows doesn't have a native About dialog. This PR reuses the
electron::ShowMessageBoxfunction to generate a dialog with the About Panel information as a string message.Notes:
applicationNameandapplicationVersionprovided by/src/base/file_version_info.h.NativeImageAPI does.Fields added (all optional):
applicationName: stringapplicationVersion: stringcopyright: stringcredits: stringiconPath: stringcc @codebytere @ckerr @sindresorhus
Example
Additional Reading
Microsoft UX Guidelines for Dialog Boxes: https://docs.microsoft.com/en-us/windows/win32/uxguide/win-dialog-box
Relevant bits:
Checklist
npm testpassesRelease Notes
Notes: Added about panel customization on Windows.