{{ message }}
Expose IsOffScreen method always to JS.#12530
Merged
Merged
Conversation
MarshallOfSound
added
semver/minor
Member
Contributor
Author
|
Well, as I mentioned, in 2.0 there's code which calls Since this API is available under normal circumstances, would we still say we're adding it? |
MarshallOfSound
added
target/2-0-x
and removed
semver/minor
Member
|
Seems legit 👍 Sounds like a bug fix to me 😄 |
alexeykuzmin
approved these changes
Apr 4, 2018
ckerr
approved these changes
Apr 4, 2018
ckerr
left a comment
ckerr
left a comment
Member
There was a problem hiding this comment.
isOffscreen() is in the 2-0-x documentation, so I agree this is a bugfix rather than a feature addition
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isOffscreenshould be available to JS even when OSR is disabled in build.This needs to be backported to 2.0, where
isOffscreenis actually called fromlib/browser/rpc-server.js