@ckerr Updated 👍

@codebytere when do you think this will be released?

@sallar it's on the table for 2.0, i believe, so fairly soon

not include in 2.0 beta1?

@HuChundong It should be, do you have a case where it's not working?

@MarshallOfSound
yes,there is something wrong with me, at first i'm sorry for my poor english,thanks for your quick reply
mainWindow = new BrowserWindow({ height: 540, minHeight: 540, width: 830, minWidth: 830, useContentSize: true, webPreferences: {webSecurity: false}, resizable: true, alwaysOnTop: false, transparent: true, show: false, frame: false, titleBarStyle: 'hiddenInset', vibrancy: 'ultra-dark' })

this main window still lose round corner in high sierra 10.13.3
i need to set fullscreen and then exit full screen to get round corner back

This PR was not intended to fix the round / square corner issue. There is a separate open issue for that

Hi, I don't know what I am doing wrong but this is still not working for me... running MacOS 10.13.3. I still get the same error of the transparent bar showing up.
Here is my window code:

function createWindow() {
	var bounds = electron.screen.getPrimaryDisplay().workAreaSize;

	/*
	* Fix the issue where the window bounds are not correct in windows 10
	*/
	var shouldMaximize;
	if (process.platform == 'win32') {
		if (bounds.x === 0 || bounds.y === 0 || bounds.x === -8 || bounds.y === -8) {
        	var screenSize = electron.screen.getPrimaryDisplay().workAreaSize
        	if ((screenSize.width === bounds.width || bounds.width - screenSize.width === 16) && (screenSize.height === bounds.height || bounds.height - screenSize.height === 16)) {
          		shouldMaximize = true
        	}
      	}
	}

	mainWindow = new electron.BrowserWindow({
		width: bounds.width,
		minWidth: 300,
		height: bounds.height,
		minHeight: 430,
		x: 0,
		y: 0,
		titleBarStyle: 'hidden-inset',
		show: false,
		frame: false,
		vibrancy: 'light'
	});

	if (shouldMaximize) {
		mainWindow.maximize();
	}

	if (process.platform == 'win32') {
		mainWindow.setMenu(null);
	}

	mainWindow.loadURL(path.join('file://', __dirname, '/public/app/index.html'));

	mainWindow.once('ready-to-show', function() {
		mainWindow.show();
	});

	mainWindow.on('closed', function() {
		mainWindow = null;
	});
}

@huangruichang @tcaer Remove frame: false from your configs to see if it makes any difference.

@sallar Maybe I am not the person you wanna notice 🤣

@sallar No luck... I get the square corners and the invisible tab :/

@tcaer Can you share repro?

@tcaer add transparent: true. The invisible tab should disappear but that was working even before this PR. There's no fix for the rounded corners though.

Judging by your comments this PR fixes nothing.

I just tested beta1. This fix changes nothing. Vibrancy+Square Corners was also possible before (using transparent: true and frame: false). This issue should be re-opened?

But judging by @MarshallOfSound's comment, there is a separate issue for the rounded corners... #10886

Also just tested and unfortunately I'm also seeing much worse behavior than before the fix.

Previously there was just a transparent area where the titlebar would normally be – now it's showing corrupted artifacts and the titlebar has reverted to the standard thickness / position even with titleBarStyle: "hidden-inset" window option.

@tommoor Super weird, let me test this real quick 🤔

@tommoor Two quick things

• hidden-inset shouldn't be an option in 2.0.0-beta.1 it has been replaced with hiddenInset (the other one was deprecated for a while)
• Can you share your exact browser window constructor options object, I can't repro what you have a screenshot of

Oh, interesting I did check the release notes for breaking changes and there wasn't a mention of that property being deprecated but that would explain the first part of the issue 😄. I wonder if having the deprecated option there caused it. Was the deprecation removed in 2.0? If so I guess we should add that to the notes.

The screenshot doesn't capture it too well, basically the entire titlebar is showing artifacts depending on what's behind - It mostly looks black / transparent. Options are:

{
      titleBarStyle: "hidden-inset",
      acceptFirstMouse: true,
      file: "index",
      webPreferences: { scrollBounce: true, textAreasAreResizable: false },
      x,
      y,
      width,
      height
}

These are two screenshots off current master using

{
  vibrancy: 'dark',
  titleBarStyle: 'hiddenInset',
  transparent: true,
  frame: false,
}

And just to prove no bamboozle, here is a screenshot from electron-quick-start using the above config using electron@2.0.0.-beta.1

Thanks @MarshallOfSound – I'm out for the day now, but I'll try with 2.0 again tomorrow and the correct hiddenInset option, hopefully that does the trick 👍

@tommoor It might also be the frame and transparent options helping out, let me know if you can't make it look like mine 😆

Maybe, I can't really use those options as the square corners are unacceptable on macOS unfortunately 😞

Hm, fair enough, we had an issue somewhere for the square corner thing. Will try take a look at that later this week if I get a chance.

Thanks so much for all the help!
There is also another bug I get when closing an app (I am using the current beta). MacOS reports that the app crashed even though it didn't.

@tcaer Known bug and I think it's already fixed 😆

Hey guys, thanks so much for fixing this!

Does this fix the corner radius bug too? In my build, the top two corners aren't rounded when I use the following settings with a webview in it #10522:

titleBarStyle: 'default',
transparent: true,
vibrancy: 'dark',

Rounded corners are still missing at the top edges, when vibrancy is activated.
Tested in Electron 2.0.2