add accessory view for format picker by codebytere · Pull Request #11873 · electron/electron · GitHub
Skip to content

add accessory view for format picker#11873

Merged
codebytere merged 3 commits into
masterfrom
add-file-format-picker
Feb 11, 2018
Merged

add accessory view for format picker#11873
codebytere merged 3 commits into
masterfrom
add-file-format-picker

Conversation

@codebytere

@codebytere codebytere commented Feb 9, 2018

Copy link
Copy Markdown
Member

Resolves #10335.

Allows for saveDialog to list available file extensions in a format picker button. Tested locally on MacOS, sadly no real way to test this one programmatically.

Todo:

  • implement selector action to change extension in top textbar

@codebytere codebytere requested a review from a team February 9, 2018 14:10
@codebytere codebytere changed the title add accessory view for format picker [WIP] add accessory view for format picker Feb 9, 2018
@codebytere codebytere changed the title [WIP] add accessory view for format picker add accessory view for format picker Feb 10, 2018

@MarshallOfSound MarshallOfSound left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending builds 👍

@codebytere codebytere merged commit 647f0f3 into master Feb 11, 2018
@codebytere codebytere deleted the add-file-format-picker branch February 11, 2018 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants