{{ message }}
Fix child touch bar items not updating#11812
Merged
Merged
Conversation
Deep children of a TouchBar didn't cause the top level touch bar to update, now they do Fixes #11761.
MarshallOfSound
force-pushed
the
fix-child-touch-bar-items
branch
from
062588d to
b55a770
Compare
Member
Author
ckerr
reviewed
Feb 2, 2018
ckerr
left a comment
ckerr
left a comment
Member
There was a problem hiding this comment.
Code basically LGTM.
Any chance of getting tests for this, or is that too hard to set up?
codebytere
approved these changes
Feb 12, 2018
codebytere
left a comment
codebytere
left a comment
Member
There was a problem hiding this comment.
per @MarshallOfSound there doesn't really seem to be better way to do tests for this, so 👍
sethlu
pushed a commit
to sethlu/electron
that referenced
this pull request
May 3, 2018
* Fix child touch bar items not updating Deep children of a TouchBar didn't cause the top level touch bar to update, now they do Fixes electron#11761. * Remove unused newValue property in TB setter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deep children of a TouchBar didn't cause the top level touch bar to update, now they do
Fixes #11761.