{{ message }}
Make MenuItem roles camelCase-compatible#11532
Merged
Merged
Conversation
sethlu
force-pushed
the
camelcase-menuitem-role
branch
from
32ab989 to
d45914c
Compare
Member
Contributor
Author
|
@codebytere cool! I’ll do that a little later today 👍 |
Member
|
hey @sethlu, it looks like you're failing |
The MenuItem role should be lowercase
Contributor
Author
|
@codebytere I forgot to run the test cases again... 😢 Should work now. |
codebytere
approved these changes
Jan 4, 2018
codebytere
left a comment
codebytere
left a comment
Member
There was a problem hiding this comment.
This looks good to me! Appreciate the standardization :)
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating MenuItem roles to be in camelCase while keeping backward lowercase compatibility.
Closes #10372
CC: @zeke