{{ message }}
Add support for openAI client 1.1+, drop support for older versions#607
Merged
Conversation
1 task
codefromthecrypt
previously approved these changes
Apr 15, 2025
codefromthecrypt
left a comment
codefromthecrypt
left a comment
Contributor
There was a problem hiding this comment.
Agree to "draw a line in the sand"
jackshirazi
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first stable OpenAI Java client (1.0.0) was released a few days ago.
This PR adds support for 1.1+ and drops support for all older versions.
1.0 seems to have moved a lot of classes around causing breaking changes, but looks like nothing functionally changed.
I didn't touch the logic and all tests are green.
I decided to only support 1.1+, as the way to extract the
baseUrlfrom the client builder changed and 1.1 was released only a few hours after 1.0. Therefore I don't think it's worth adding a special case / separate module to support 1.0.