[ci] another fix in the release changelog generation by SylvainJuge · Pull Request #1077 · elastic/elastic-otel-java · GitHub
Skip to content

[ci] another fix in the release changelog generation#1077

Merged
SylvainJuge merged 3 commits into
elastic:mainfrom
SylvainJuge:release-changelog-fix-again
Apr 27, 2026
Merged

[ci] another fix in the release changelog generation#1077
SylvainJuge merged 3 commits into
elastic:mainfrom
SylvainJuge:release-changelog-fix-again

Conversation

@SylvainJuge

Copy link
Copy Markdown
Member

should fix https://github.com/elastic/elastic-otel-java/actions/runs/25006685693/job/73231276957

  • invalid input path for the release yaml
  • standard output of doc-builder invocation should be removed

@github-actions

github-actions Bot commented Apr 27, 2026

Copy link
Copy Markdown

Comment thread .github/workflows/release-step-3.yml
Comment thread .github/workflows/release-step-3.yml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the release workflow step that generates changelog/release notes, aligning docs-builder inputs/outputs with the repo’s release YAML layout and suppressing unwanted command output to avoid CI failures.

Changes:

  • Switch docs-builder changelog render to use docs/releases/<version>.yaml as input.
  • Suppress docs-builder stdout during release-notes generation.
Comments suppressed due to low confidence (1)

.github/workflows/release-step-3.yml:240

  • There are two consecutive cat "${tmp}/${{ env.RELEASE_VERSION }}/index.md" lines, and the first one ends with a trailing \. With the continuation, the shell will effectively run cat <file> cat <file> | sed ..., which breaks the pipeline (and typically errors with cat: cat: No such file or directory). Remove the duplicate cat and keep a single pipeline into sed.
          cat "${tmp}/${{ env.RELEASE_VERSION }}/index.md" \
            | sed -e "/## ${{ env.RELEASE_VERSION }} \[elastic-release-notes-${{ env.RELEASE_VERSION }}/d" \
            | sed -e "/###/s/ \[elastic-${{ env.RELEASE_VERSION }}.*$//g" >> $GITHUB_OUTPUT
          echo 'RELNOTESEOF' >> $GITHUB_OUTPUT

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release-step-3.yml
@SylvainJuge SylvainJuge marked this pull request as ready for review April 27, 2026 16:41
@SylvainJuge SylvainJuge requested review from a team as code owners April 27, 2026 16:41
@SylvainJuge SylvainJuge enabled auto-merge (squash) April 27, 2026 16:41
@coderabbitai

coderabbitai Bot commented Apr 27, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: fe9ad2b3-0ee0-4c5a-8b21-e27794bd24c1

📥 Commits

Reviewing files that changed from the base of the PR and between 3e4b69f and 1c057f6.

📒 Files selected for processing (1)
  • .github/workflows/release-step-3.yml

📝 Walkthrough

Walkthrough

The release workflow's changelog rendering step has been updated to source the YAML file from a version-specific path at docs/releases/${RELEASE_VERSION}.yaml rather than a temporary directory path. The command output from the docs-builder changelog render operation is now suppressed by redirecting stdout to /dev/null, while the subsequent file read operation for GitHub output processing continues as before. The net change involves 4 added lines and 1 removed line with no impact to public APIs or exports.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SylvainJuge SylvainJuge merged commit 18eb9da into elastic:main Apr 27, 2026
22 of 23 checks passed
@SylvainJuge SylvainJuge deleted the release-changelog-fix-again branch April 27, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants