Also support version on go install by thbkrkr · Pull Request #87 · elastic/crd-ref-docs · GitHub
Skip to content

Also support version on go install#87

Merged
thbkrkr merged 2 commits into
masterfrom
support-version-go-install
Jul 25, 2024
Merged

Also support version on go install#87
thbkrkr merged 2 commits into
masterfrom
support-version-go-install

Conversation

@thbkrkr

@thbkrkr thbkrkr commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

This makes the version command also works when the binary is installed using go install.

Follow-up of #78 and #84.

@thbkrkr thbkrkr added the enhancement New feature or request label Jul 25, 2024
Comment thread main.go Outdated
@thbkrkr thbkrkr force-pushed the support-version-go-install branch from 7ad167d to a7eeb94 Compare July 25, 2024 10:52
@thbkrkr

thbkrkr commented Jul 25, 2024

Copy link
Copy Markdown
Contributor Author

@barkbay barkbay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thbkrkr thbkrkr merged commit 0ad85c5 into master Jul 25, 2024
@thbkrkr thbkrkr mentioned this pull request Jul 25, 2024
@thbkrkr thbkrkr deleted the support-version-go-install branch July 25, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants