{{ message }}
Support rendering consts that are enum values for a type defined in package#79
Merged
Conversation
enumeration types.
Contributor
Author
|
/retest |
Contributor
Author
thbkrkr
reviewed
Apr 12, 2024
thbkrkr
left a comment
thbkrkr
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall, maybe take care of the naming a little more and see how to improve the readability of this new function.
thbkrkr
approved these changes
Apr 13, 2024
thbkrkr
left a comment
thbkrkr
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @liorokman.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support to extract information about const values of aliased enumeration types.
Fixes #54