Support for generating separate files for each group by airycanon · Pull Request #67 · elastic/crd-ref-docs · GitHub
Skip to content

Support for generating separate files for each group#67

Merged
thbkrkr merged 1 commit into
elastic:masterfrom
airycanon:feat/output-mode
Mar 7, 2024
Merged

Support for generating separate files for each group#67
thbkrkr merged 1 commit into
elastic:masterfrom
airycanon:feat/output-mode

Conversation

@airycanon

Copy link
Copy Markdown
Contributor

Resolve #59

@cla-checker-service

cla-checker-service Bot commented Mar 1, 2024

Copy link
Copy Markdown

@airycanon

Copy link
Copy Markdown
Contributor Author

@thbkrkr @tenstad Could you please take a look at this pull request?

@thbkrkr thbkrkr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good overall, but I would write it slightly differently.

Comment thread renderer/renderer.go Outdated
Comment thread renderer/renderer.go
Comment thread renderer/renderer.go Outdated
Comment thread main.go Outdated
@airycanon

Copy link
Copy Markdown
Contributor Author

It looks good overall, but I would write it slightly differently.

Thank you for the review and the suggestions! I've made the recommended improvements. Could you please take another look?

@thbkrkr thbkrkr added the enhancement New feature or request label Mar 7, 2024
@thbkrkr thbkrkr changed the title add output mode option Support for generating separate files for each group Mar 7, 2024
@thbkrkr thbkrkr merged commit 83e2ff3 into elastic:master Mar 7, 2024
@thbkrkr

thbkrkr commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Support for outputting multiple files

2 participants