{{ message }}
feat: improve parsing#51
Merged
Merged
Conversation
Signed-off-by: Amund Tenstad <github@amund.io>
Contributor
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
81eb5f7 to
319af4e
Compare
Contributor
Author
|
Added the test in two commits, where the 2nd (319af4e) shows the changes introduced by this PR. |
Contributor
Author
|
Wondering if we should update the rendering so that the test types we added renders as they used to 🤔 |
Contributor
Author
|
Having different descriptions, I guess it is nice to show both Underlying1 and Underlying2 :) |
Contributor
Contributor
Author
thbkrkr
approved these changes
Oct 6, 2023
thbkrkr
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
We really appreciate your contribution, thanks again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Simplifies a lot of the complexity of having separate
processType,loadTypeandloadAliasType.Removes ArrayKind, as it is not supported by controller-gen.
Also ensures correct parsing of
Ain the example below, makingA.UnderlyingTypeequalBinstead ofstring. This will be required to correctly parse and propagate markers (#49).