Add support for Markdown by unguiculus · Pull Request #16 · elastic/crd-ref-docs · GitHub
Skip to content

Add support for Markdown#16

Merged
thbkrkr merged 2 commits into
elastic:masterfrom
unguiculus:feature/markdown
Nov 22, 2021
Merged

Add support for Markdown#16
thbkrkr merged 2 commits into
elastic:masterfrom
unguiculus:feature/markdown

Conversation

@unguiculus

Copy link
Copy Markdown
Contributor
  • Add renderer for Markdown
  • Add templates for Markdown
  • Add Markdown tests to test.sh

* Add renderer for Markdown
* Add templates for Markdown
* Add Markdown tests to test.sh

@thbkrkr thbkrkr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you. Almost LGTM. I left a few minor comments.

Comment thread README.md Outdated
Comment thread test.sh
Comment thread renderer/markdown.go
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
@unguiculus unguiculus requested a review from thbkrkr November 5, 2021 13:07
@thbkrkr thbkrkr merged commit b15937a into elastic:master Nov 22, 2021
@unguiculus unguiculus deleted the feature/markdown branch November 24, 2021 14:25
@thbkrkr thbkrkr added the enhancement New feature or request label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants