Add CONTRIBUTING.md by charith-elastic · Pull Request #10 · elastic/crd-ref-docs · GitHub
Skip to content

Add CONTRIBUTING.md#10

Merged
charith-elastic merged 2 commits into
elastic:masterfrom
charith-elastic:docs/contributing
Feb 17, 2021
Merged

Add CONTRIBUTING.md#10
charith-elastic merged 2 commits into
elastic:masterfrom
charith-elastic:docs/contributing

Conversation

@charith-elastic

Copy link
Copy Markdown
Contributor

No description provided.

@charith-elastic charith-elastic added the documentation Improvements or additions to documentation label Feb 16, 2021

@barkbay barkbay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should it be also mentioned in a PR template ?

Comment thread CONTRIBUTING.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: markdownlint is complaining with the following messages:

MD041/first-line-heading/first-line-h1: First line in file should be a top level heading

IIRC = is an alternative that should be used below the text.

@charith-elastic charith-elastic merged commit 3a36eb9 into elastic:master Feb 17, 2021
@charith-elastic charith-elastic deleted the docs/contributing branch February 17, 2021 08:24
charith-elastic added a commit to charith-elastic/crd-ref-docs that referenced this pull request Feb 19, 2021
* Add CONTRIBUTING.md

* Fix header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants