{{ message }}
Repository navigation
fix: make extension_version.published_by_id NOT NULL - #2276
Merged
Merged
Conversation
Changes * added migration; just sets NOT NULL constraint as there should be no NULL values * modified ExtensionVersion: @manytoone on publishedBy becomes @manytoone(optional = false) plus @joincolumn(name = "published_by_id", nullable = false) * left in places null checks in rest of the places; they are no redundant, null is enforced at DB level * fixed tests that now failed (did not set user on entity) * added one test that ensures that persisting with null user fails fixes: #2266
Contributor
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Generated jOOQ metadata remains stale, and several new publisher fixtures are not cleaned from the shared test database.
Review effort: Balanced
Findings: 4
Open (4)
What changed in this PR
Enforces non-null publishers for extension versions, resolving #2266.
Changes:
- Adds the database constraint and matching JPA mapping.
- Updates affected test fixtures.
- Adds coverage for rejecting versions without publishers.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The migration should avoid scanning the full table while holding an exclusive lock.
Review effort: Balanced
Findings: 1
Open (2)
Resolved since last review (3)
Files not reviewed (1)
- server/src/main/jooq-gen/org/eclipse/openvsx/jooq/tables/ExtensionVersion.java: Generated file
Validate a NOT VALID check constraint under a weaker lock first, so the table scan doesn't run while SET NOT NULL holds the exclusive lock on extension_version. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The database, ORM, generated metadata, and tests consistently enforce the new invariant.
Review effort: Balanced
Findings: None
Resolved since last review (2)
Files not reviewed (1)
- server/src/main/jooq-gen/org/eclipse/openvsx/jooq/tables/ExtensionVersion.java: Generated file
netomi
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
fixes: #2266