{{ message }}
Repository navigation
Convert org.eclipse.cdt.core.tests.BaseTestFramework to JUnit5 - #1379
Draft
jonahgraham wants to merge 2 commits into
Draft
jonahgraham wants to merge 2 commits into
jonahgraham wants to merge 2 commits into
Conversation
With the move to JUnit5 any assertEquals methods declared in source files cause problems with resolution.
BaseTestFramework is the base class for a hierarchy of tests and all those test updates are included in this commit.
Member
Author
|
ExpressionWriterTest was being run twice before this commit because it was discovered on its own and added to another suite here: This accounts for 11 of the reduced runs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseTestFramework is the base class for a hierarchy of tests and all those test updates are included in this commit.
Includes a parent commit that deletes an unused method that interfered with the resolution of assertEquals when statically imported.
Part of #1380