{{ message }}
Repository navigation
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 12 files
Confidence score: 5/5
- In
src/i18n/locales/fr/home.json,buildMeAuses the informal “Crée-moi” while the other French strings use the formal register. Align it with the catalog’s formal tone.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/i18n/locales/fr/home.json">
<violation number="1" location="src/i18n/locales/fr/home.json:8">
P3: `buildMeA` uses the informal imperative "Crée-moi", while every other user-facing string in the French catalogs uses the formal register (settings: "Saisissez", "Choisissez", "Mettez à jour"; home.setup: "Cliquez"). Mixing tu/vous registers is jarring to French users. Use the formal form: `"Créez-moi un(e) {{label}}"`.</violation>
</file>
Reply to a comment to ask cubic a question or push back. It learns from your replies.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
P3: buildMeA uses the informal imperative "Crée-moi", while every other user-facing string in the French catalogs uses the formal register (settings: "Saisissez", "Choisissez", "Mettez à jour"; home.setup: "Cliquez"). Mixing tu/vous registers is jarring to French users. Use the formal form: "Créez-moi un(e) {{label}}".
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At src/i18n/locales/fr/home.json, line 8:
<comment>`buildMeA` uses the informal imperative "Crée-moi", while every other user-facing string in the French catalogs uses the formal register (settings: "Saisissez", "Choisissez", "Mettez à jour"; home.setup: "Cliquez"). Mixing tu/vous registers is jarring to French users. Use the formal form: `"Créez-moi un(e) {{label}}"`.</comment>
<file context>
@@ -0,0 +1,928 @@
+ "settingUp": "Nous configurons votre application grâce à la magie de l'IA.",
+ "mightTakeMoment": "Cela peut prendre un instant...",
+ "moreIdeas": "Plus d'idées",
+ "buildMeA": "Crée-moi un(e) {{label}}",
+ "failedCreateApp": "Échec de la création de l'application. {{error}}",
+ "failedCreateChat": "Échec de la création du chat. {{error}}",
</file context>
Suggested change
Register the fr catalogs (common, settings, chat, home, errors) with i18next, list Français in the language selector, and cover it with a key and placeholder parity test plus a localized billing banner case. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HfGXChcifsLyZoBLEctxXA
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
- Add the 15 English keys added on main since the French catalogs were written (safety review, queued test runs, dev server, preview auth). - Write French non-breaking spaces as the JSON escape, as rules/i18n.md requires. - Assert one key per namespace through i18next so dropping fr from a namespace in src/i18n/index.ts fails the test. - Drop the stale "other four locales" count in rules/i18n.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
azizmejri1
force-pushed
the
feat/i18n-french
branch
from
October 5, 2026 19:03
514ce07 to
c7199a8
Compare
github-actions
Bot
added
the
needs-human:review-issue
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focused follow-up to #4705, which was closed because it mixed in unrelated changes. This PR contains only the French translation: no renaming, no default-language change, no Ollama or packaging work.
Changes
src/i18n/locales/fr/*.json: French catalogs forcommon,settings,chat,homeanderrors, in sync with the currentenkeys onmain.src/i18n/index.ts: registers thefrresources.src/components/LanguageSelector.tsx: lists "Français" (fris already inLanguageSchema).src/i18n/fr_locale.test.ts: key and{{placeholder}}parity withen, onei18n.tlookup per namespace so a missing registration fails, and French plural forms.test_gate_locales.test.tsandSubscriptionStatusBanner.test.tsxcoverfr.rules/i18n.mdandPRODUCT.mdlist the current locales and the French non-breaking-space convention (:,?,!and inside « »).The cubic review notes from #4705 that apply to these files are addressed: namespace registration coverage,
Testing
npx vitest run src/i18n src/components/SubscriptionStatusBanner.test.tsx: 41 passednpm run ts,prettier --checkandoxlintare clean.🤖 Generated with Claude Code