{{ message }}
fix(test): migrate test runner to vscode-test#1
Merged
Conversation
tieubao
approved these changes
Apr 9, 2025
Attempts to resolve 'spawn ENOENT' and subsequent 'SIGKILL' errors during integration test execution using @vscode/test-electron. - Uses the executable path directly returned by downloadAndUnzipVSCode. - Adds logic to correct potentially malformed paths reported by the library (e.g., removing extraneous '.app' segment). - Addresses macOS quarantine issues via xattr (though the root cause appears to be corrupted download/extraction). The downloaded VS Code instance still seems damaged or incorrectly extracted by the library, preventing successful test runs. Manual VS Code installation might be required as a workaround.
monotykamary
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the VS Code extension test runner from
@vscode/test-electronto the oldervscode-testlibrary and adds flags to potentially support headless CI environments.Reason:
@vscode/test-electron.vscode-test, being the more established library, might offer better compatibility in this scenario.Missing X server or $DISPLAY) when running tests in headless CI environments like GitHub Actions.Changes:
@vscode/test-electron.vscode-testand its peer dependencies (mocha,@types/mocha,@types/glob).src/test/runTest.tsto use thevscode-testAPI.src/test/runTest.tsto include--disable-gpuand--no-sandboxlaunch arguments when theCIenvironment variable is detected. (Note: Usingxvfbin the CI workflow is the recommended approach, but this is an attempt to fix it via launch args).