{{ message }}
Repository navigation
fix out-of-bounds read in string to struct cast - #23384
Merged
Mytherin merged 1 commit intoJun 23, 2026
Merged
Conversation
duckdb-draftbot
marked this pull request as draft
June 20, 2026 09:43
Member
jmestwa-coder
force-pushed
the
struct-cast-oob-read
branch
from
June 22, 2026 13:37
e8889ab to
28aa0a2
Compare
Contributor
Author
|
done, rebased onto |
Mytherin
marked this pull request as ready for review
June 22, 2026 15:36
Member
kaka11chen
pushed a commit
to kaka11chen/astrovela_vane
that referenced
this pull request
Aug 14, 2026
**Out-of-bounds read in SplitStruct**
After consuming the opening `{`/`(` and skipping whitespace, the
empty-struct check reads `buf[pos]` without testing `pos` against `len`,
so a non-inlined string that is just the opening character followed by
spaces reads one byte past the buffer. The list and map splitters
already guard this spot (`pos < len` / `pos == len`); matched the struct
path to them.
ASan on `CAST('{ ' AS STRUCT(a INTEGER))` before the fix:
```
ERROR: AddressSanitizer: heap-buffer-overflow ... READ of size 1
#0 ... duckdb::VectorStringToStruct::SplitStruct(...) vector_cast_helpers.cpp:462
```
Upstream-Commit: duckdb/duckdb@15d896e
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Out-of-bounds read in SplitStruct
After consuming the opening
{/(and skipping whitespace, the empty-struct check readsbuf[pos]without testingposagainstlen, so a non-inlined string that is just the opening character followed by spaces reads one byte past the buffer. The list and map splitters already guard this spot (pos < len/pos == len); matched the struct path to them.ASan on
CAST('{ ' AS STRUCT(a INTEGER))before the fix: