{{ message }}
Repository navigation
[Variant] Fix crash for variant_extract on non-object shredded column - #23303
Merged
Merged
Conversation
…here root NULL values weren't counting towards VariantColumnStatsData::total_count in variant shredding analysis. This change affects all VariantVisitor implementations that define VisitMetadata
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes https://github.com/duckdblabs/duckdb-internal/issues/9335
Misc
Also fixes dormant issue where root NULL values weren't counting towards VariantColumnStatsData::total_count in variant shredding analysis.
This change affects all VariantVisitor implementations that define VisitMetadata, as it's now also called for root NULL values.