MSVC 14.51 (VS 18) removed stdext::checked_array_iterator but its STL
still defines _SECURE_SCL, so DuckDB v1.5.3's vendored fmt takes the
checked-iterator path and fails to compile (duckdb/duckdb#22704).

Mirror duck-orch's working fix: /FI a shim that includes <iterator> and
<string> first, then undefines _SECURE_SCL, so fmt's #ifdef _SECURE_SCL
branch is never taken. Applied only for MSVC_VERSION >= 1950; remove
once community-extensions pins a DuckDB release containing
duckdb/duckdb#23238.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

The windows-latest GitHub runner image rolled over to the Visual Studio 18
toolset, which removed stdext::checked_array_iterator. duckdb's bundled fmt
still referenced it at the previous pin, so every Windows build fails with:

  fmt/format.h(326): error C2653: 'stdext': is not a class or namespace name

duckdb backported the fmt fix to its v1.5-variegata branch in duckdb/duckdb#23238.
Bump the submodule from 2115a29 (head of duckdb/duckdb#23057) to 4d8c2978, the
current duckdb v1.5-variegata tip, which contains 2115a29 plus the fmt fix and
a few variant fixes - and keeps the same extension-facing API.

https://claude.ai/code/session_0197MwysFD3m2LaGSxB8jd2i

This is a backport of the PR #22706 (#23238 in 1.5) to `v1.4-andium`
stable branch.

This PR removes [stdext::checked_array_iterator](https://learn.microsoft.com/en-us/cpp/standard-library/checked-array-iterator-class?view=msvc-180)
usage applying the changes from [this commit](fmtlib/fmt@9bea6ec)
to the version of the `fmt` library included in the `third_party` dir.

It is checked on Visual Studio 18.6.0 released on May 12.

Fixes: #22704

Equivalent to #23239, but new to
restart CI properly.

---

This is a backport of the PR #22706 (#23238 in 1.5) to `v1.4-andium`
stable branch.

This PR removes
[stdext::checked_array_iterator](https://learn.microsoft.com/en-us/cpp/standard-library/checked-array-iterator-class?view=msvc-180)
usage applying the changes from [this
commit](fmtlib/fmt@9bea6ec)
to the version of the `fmt` library included in the `third_party` dir.

It is checked on Visual Studio 18.6.0 released on May 12.

Fixes: #22704

This is a backport of the PR #22706 (#23238 in 1.5) to `v1.4-andium`
stable branch.

This PR removes [stdext::checked_array_iterator](https://learn.microsoft.com/en-us/cpp/standard-library/checked-array-iterator-class?view=msvc-180)
usage applying the changes from [this commit](fmtlib/fmt@9bea6ec)
to the version of the `fmt` library included in the `third_party` dir.

It is checked on Visual Studio 18.6.0 released on May 12.

Fixes: #22704

This is a backport of the PR #22706 (#23238 in 1.5) to `v1.4-andium`
stable branch.

This PR removes
[stdext::checked_array_iterator](https://learn.microsoft.com/en-us/cpp/standard-library/checked-array-iterator-class?view=msvc-180)
usage applying the changes from [this
commit](fmtlib/fmt@9bea6ec)
to the version of the `fmt` library included in the `third_party` dir.

It is checked on Visual Studio 18.6.0 released on May 12.

Fixes: #22704

Conflict-free merge of the clean commits between resolutions:
  - Fix VARIANT shredding, avoid including empty object keys (duckdb#23213)
  - Remove checked_array_iterator from fmt dep (1.5) (duckdb#23238)
  - [Dev] Add missing `ORDER BY ALL` or `rowsort` to merge into tests (duckdb#23258)

This is a backport of the PR duckdb#22706 to `v1.5-variegata` stable branch.

This PR removes
[stdext::checked_array_iterator](https://learn.microsoft.com/en-us/cpp/standard-library/checked-array-iterator-class?view=msvc-180)
usage applying the changes from [this
commit](fmtlib/fmt@9bea6ec)
to the version of the `fmt` library included in the `third_party` dir.

It is checked on Visual Studio 18.6.0 released on May 12.

Fixes: duckdb#22704

Conflict-free merge of the clean commits between resolutions:
  - Fix VARIANT shredding, avoid including empty object keys (duckdb#23213)
  - Remove checked_array_iterator from fmt dep (1.5) (duckdb#23238)
  - [Dev] Add missing `ORDER BY ALL` or `rowsort` to merge into tests (duckdb#23258)

Brings these v1.5-variegata commits; they do not overlap with the main/v2.0
line, so they merge with no conflicts:

- Fix VARIANT shredding, avoid including empty object keys (duckdb#23213)
- Remove checked_array_iterator from fmt dep (1.5) (duckdb#23238)
- [Dev] Add missing `ORDER BY ALL` or `rowsort` to merge into tests (duckdb#23258)

Brings these v1.5-variegata commits; they do not overlap with the main/v2.0
line, so they merge with no conflicts:

- Fix VARIANT shredding, avoid including empty object keys (duckdb#23213)
- Remove checked_array_iterator from fmt dep (1.5) (duckdb#23238)
- [Dev] Add missing `ORDER BY ALL` or `rowsort` to merge into tests (duckdb#23258)

This is a backport of the PR #22706 to `v1.5-variegata` stable branch.

This PR removes
[stdext::checked_array_iterator](https://learn.microsoft.com/en-us/cpp/standard-library/checked-array-iterator-class?view=msvc-180)
usage applying the changes from [this
commit](fmtlib/fmt@9bea6ec)
to the version of the `fmt` library included in the `third_party` dir.

It is checked on Visual Studio 18.6.0 released on May 12.

Fixes: #22704

Upstream-Commit: duckdb/duckdb@4d8c297