{{ message }}
Repository navigation
MergeInto: correctly clean-up buffer and handle non trivial GetData - #20163
Merged
Merged
Conversation
carlopi
marked this pull request as ready for review
December 12, 2025 13:44
lnkuiper
reviewed
Dec 16, 2025
duckdb-draftbot
marked this pull request as draft
December 16, 2025 12:45
carlopi
marked this pull request as ready for review
December 16, 2025 12:46
carlopi
marked this pull request as draft
December 16, 2025 13:52
carlopi
marked this pull request as ready for review
December 16, 2025 14:31
Member
Member
Author
@staticlibs: I am not sure how that can be done, given #19415 has been merged in main, and this targets the |
Member
…m branch This would need to be first merged into main, and then reverted, for added fun
carlopi
force-pushed
the
fixup_merge_into
branch
from
December 16, 2025 20:36
e79a0ae to
1cc1ab7
Compare
duckdb-draftbot
marked this pull request as draft
December 16, 2025 20:48
carlopi
marked this pull request as ready for review
December 16, 2025 21:46
Member
github-actions Bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 31, 2025
Split statements by semicolon (duckdb/duckdb#20174) Internal duckdb/duckdb#6881: 2025c Time Zones (duckdb/duckdb#20258) Bump Julia to v1.4.3 (duckdb/duckdb#20248) [Chore] Clean up CI nightly run to prevent time outs (duckdb/duckdb#20150) Fix extentension-ci-tools to latest release version in the v1.4-andium branch (duckdb/duckdb#20227) MergeInto: correctly clean-up buffer and handle non trivial GetData (duckdb/duckdb#20163)
github-actions Bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 31, 2025
Split statements by semicolon (duckdb/duckdb#20174) Internal duckdb/duckdb#6881: 2025c Time Zones (duckdb/duckdb#20258) Bump Julia to v1.4.3 (duckdb/duckdb#20248) [Chore] Clean up CI nightly run to prevent time outs (duckdb/duckdb#20150) Fix extentension-ci-tools to latest release version in the v1.4-andium branch (duckdb/duckdb#20227) MergeInto: correctly clean-up buffer and handle non trivial GetData (duckdb/duckdb#20163) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been made visible through testing code in
mainbranch, but this is currently off in case of GetData returning non trivial GetData such asHAVE_MORE_OUTPUTand 0 results (both since it will not loop back AND since it will NOT cleanup results).