{{ message }}
Repository navigation
Add getPosAtLineNumber - #893
Open
HoldYourWaffle wants to merge 1 commit into
Open
HoldYourWaffle wants to merge 1 commit into
HoldYourWaffle wants to merge 1 commit into
Conversation
Contributor
Owner
|
Thanks @Gerrit0 for that suggestion! I didn't know about that. @HoldYourWaffle what do you think about updating this PR to use that API? It might be nice if it caches stuff for performance and reduces allocations. I think it might be 0-indexed, but ts-morph is 1-indexed. |
Contributor
Author
dsherret
force-pushed
the
latest
branch
2 times, most recently
from
February 18, 2021 19:19
9a759dc to
f0fc1a0
Compare
dsherret
force-pushed
the
latest
branch
4 times, most recently
from
May 1, 2021 21:35
dedc584 to
a7072fc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have never encountered as many off-by-one-ish errors as I have today...
However, as far as I can tell this function is now working properly 😄
I also changed a comment somewhere to be more clear about what is 1-indexed.
Closes #891.