{{ message }}
Repository navigation
fix: keep getter-based names when adding methods from structures - #1693
Open
kerdofficial wants to merge 1 commit into
Open
kerdofficial wants to merge 1 commit into
kerdofficial wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1527
insertMethods()copied each structure with{ ...s }. A spread only copies own enumerable properties, so a structure class with anamegetter lost its name and the insert failed with a ManipulationError.The copy isn't needed: nothing in the insert path writes to the passed structures (overload defaults are applied to their own copies). This removes it.
Added a test with a getter-based
name(fails without the change), and one that passes frozen structures to show the input is not modified.deno task test,deno task code-verificationanddeno task type-checkpass.