{{ message }}
Repository navigation
fix(common): avoid tracking directories during file reads - #1691
Open
mayankdhingra02 wants to merge 1 commit into
Open
mayankdhingra02 wants to merge 1 commit into
mayankdhingra02 wants to merge 1 commit into
Conversation
Check tracked ancestors without creating directory records when validating a file read. Missing source-file probes no longer make recursive directory probes treat missing paths as present, and reads preserve queued deletions. Fixes dsherret#1554. Signed-off-by: Mayank Dhingra <mayankdhingra02@gmail.com>
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading a missing source file records its parent directories in the transactional file system. A later recursive
addDirectoryAtPathIfExiststreats those directories as present and throws while enumerating them.Validate reads against the nearest tracked ancestor without creating directory records. This preserves the checks for deleted or moved ancestors and lets repeated
*IfExistscalls returnundefineduntil the directory is created.Regression tests cover the reported Project calls, synchronous and asynchronous missing reads, and an untracked descendant of a directory queued for deletion.
Fixes #1554.
Validation:
deno task build,deno task --recursive test:ci(5,397 passing),deno task --recursive ensure-no-project-compile-errors,deno task --recursive code-verification, anddeno run -A npm:dprint check.The Deno CI path also passed:
deno task build:deno,deno test --allow-read(2 passing), anddeno publish --dry-run.