{{ message }}
✨ replace action string with enum#1
Open
jpatel-pivotal wants to merge 1 commit into
Open
Conversation
dsharp-pivotal
force-pushed
the
testingclient
branch
2 times, most recently
from
de4c858 to
c701497
Compare
dsharp-pivotal
force-pushed
the
testingclient
branch
2 times, most recently
from
8d38f00 to
b5359d9
Compare
dsharp-pivotal
force-pushed
the
testingclient
branch
from
aceb1ee to
7517303
Compare
jpatel-pivotal
force-pushed
the
testingclient
branch
from
4218085 to
ee470d6
Compare
- only allows valid string values for action - returns injected errors only if action is valid
jpatel-pivotal
force-pushed
the
testingclient
branch
from
ee470d6 to
b409b3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr refactors
resourceActionKey.actionfrom a string to an enum.isValid()only allows valid string values for action