{{ message }}
Add support for s390x architecture - method 1#45
Open
sdarwin wants to merge 1 commit into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you attempt to run a drone job on s390x architecture, it uses the docker image from https://hub.docker.com/r/drone/git which includes arm64 and windows however s390x is missing.
There are multiple solutions:
method 1. Leverage the docker image from thegeeklab
method 2. Run buildx on a vm
method 3. Rewrite everything to use buildx instead of manifest files. Won't explore this for now.
Probably method 1 is the simplest and easiest. That's in this PR. Method 2 is also viable and I will send it as a different pull request. Choose one or the other, not both.
I have tested both of these methods, and they work fine. Optionally, if you'd like to test the results, cloud.ibm.com offers instances at hourly rates so it's not difficult to launch an s390x virtual machine and try out the resulting docker image.