{{ message }}
fix: offset new elements to prevent overlap at same position#999
Open
20syldev wants to merge 1 commit intodrawdb-io:mainfrom
Open
fix: offset new elements to prevent overlap at same position#99920syldev wants to merge 1 commit intodrawdb-io:mainfrom
20syldev wants to merge 1 commit intodrawdb-io:mainfrom
Conversation
Tables, notes, and areas were all placed at the same coordinates (transform.pan.x/y), causing every new element to stack on top of the previous ones. Now each context incrementally offsets by 20px until a free position is found. Fixes drawdb-io#736
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(transform.pan.x, transform.pan.y)when created, causing every new element to stack on top of the previous onesaddTable(DiagramContext),addNote(NotesContext), andaddArea(AreasContext): if an existing element of the same type already occupies the target position, increment both x and y by 20px until a free spot is found+20pxoffset pattern already used by theduplicatefunction inControlPanel.jsxTest plan
dataargument) are unaffectedFixes #736