[S390X] fix utf8->utf16 conversion test case failures by saitama951 · Pull Request #129789 · dotnet/runtime · GitHub
Skip to content

[S390X] fix utf8->utf16 conversion test case failures#129789

Merged
jkotas merged 3 commits into
dotnet:mainfrom
saitama951:fix_utf8_special
Jun 25, 2026
Merged

[S390X] fix utf8->utf16 conversion test case failures#129789
jkotas merged 3 commits into
dotnet:mainfrom
saitama951:fix_utf8_special

Conversation

@saitama951

@saitama951 saitama951 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

some test cases started failing with the previous fix.
#128577 (comment)

@github-actions github-actions Bot added the area-PAL-coreclr only for closed issues label Jun 24, 2026
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Jun 24, 2026
@saitama951

saitama951 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

@saitama951

saitama951 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

@Dotnet-s390x build

@Dotnet-s390x

Dotnet-s390x commented Jun 24, 2026

Copy link
Copy Markdown

Build Queued..

To cancel the current build, please comment:

@Dotnet-s390x cancel

@Dotnet-s390x

Dotnet-s390x commented Jun 24, 2026

Copy link
Copy Markdown

Build Failed
Please check the build logs: http://148.100.85.217:8080/job/dotnet-builds/83/console.

Build Error Summary 
Build FAILED.

/var/lib/jenkins/workspace/dotnet-builds/repo/src/coreclr/runtime.proj(120,5): error MSB3073: The command ""/var/lib/jenkins/workspace/dotnet-builds/repo/src/coreclr/build-runtime.sh" -cmakeargs " -DCLR_CMAKE_USE_SYSTEM_ZLIB=false" -s390x -release -portablebuild=false -keepnativesymbols -os linux -ninja -targetrid linux-s390x -cmakeargs "-DCLR_DOTNET_RID=linux-s390x" -cmakeargs "-DCLR_DOTNET_HOST_PATH='/var/lib/jenkins/workspace/dotnet-builds/repo/.dotnet/dotnet'" -cmakeargs "-DFEATURE_DYNAMIC_CODE_COMPILED=1" -component iltools " exited with code 1.
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:02:14.34
Build failed with exit code 1. Check errors above.

@saitama951

saitama951 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author 
Finished running PAL tests.

PAL Test Results:
  Passed: 305
  Failed: 0

@build-analysis build-analysis Bot mentioned this pull request Jun 24, 2026
Open
3 tasks
am11
am11 approved these changes Jun 24, 2026
View reviewed changes

@am11 am11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

This was referenced Jun 24, 2026
Open
Open
@am11 am11 requested review from janvorli and jkotas June 24, 2026 08:01
This was referenced Jun 24, 2026
Open
Open
Open
Open
@saitama951

saitama951 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Build Failed Please check the build logs: http://148.100.85.217:8080/job/dotnet-builds/83/console.
Build Error Summary

This fails because of dotnet/dotnet#7323

janvorli
janvorli approved these changes Jun 24, 2026
View reviewed changes

@janvorli janvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli

janvorli commented Jun 24, 2026

Copy link
Copy Markdown
Member

/ba-g the test failure is #116051

Copilot AI mentioned this pull request Jun 24, 2026
Closed
@saitama951

saitama951 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@Dotnet-s390x build

@Dotnet-s390x

Dotnet-s390x commented Jun 25, 2026

Copy link
Copy Markdown

Build Queued..

To cancel the current build, please comment:

@Dotnet-s390x cancel

@Dotnet-s390x

Dotnet-s390x commented Jun 25, 2026

Copy link
Copy Markdown

@build-analysis build-analysis Bot mentioned this pull request Jun 25, 2026
Open
@jkotas jkotas merged commit a5d3b22 into dotnet:main Jun 25, 2026
170 of 173 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janvorli janvorli janvorli approved these changes
@jkotas jkotas Awaiting requested review from jkotas
+1 more reviewer
@am11 am11 am11 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-PAL-coreclr only for closed issues community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@saitama951 @Dotnet-s390x @janvorli @am11 @jkotas