{{ message }}
[wasm][interp] Jiterp packedsimd shifts#114669
Merged
Merged
Conversation
ghost
added
the
Contributor
Member
Author
This was referenced Apr 15, 2025
Closed
lewing
requested review from
BrzVlad,
kotlarmilos,
pavelsavara,
steveisok and
vitek-karas
as code owners
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/mono/browser/runtime/jiterpreter-trace-generator.ts:3691
- Consider adding targeted tests to validate the early bitmask branch logic in emit_simd_2 to ensure that both the bitmask and fallback paths are exercised.
const bitmask = bitmaskTable[index];
kg
approved these changes
Apr 15, 2025
This was referenced Apr 24, 2025
[Perf] Linux/x64: 4 Improvements on 4/14/2025 12:19:10 AM +00:00
dotnet/perf-autofiling-issues#54227
Open
[Perf] Linux/x64: 2 Improvements on 4/16/2025 12:01:44 PM +00:00
dotnet/perf-autofiling-issues#54409
Closed
[Perf] Linux/x64: 30 Improvements on 4/16/2025 3:38:42 AM +00:00
dotnet/perf-autofiling-issues#54408
Closed
[Perf] Linux/x64: 6 Improvements on 4/15/2025 10:52:02 PM +00:00
dotnet/perf-autofiling-issues#54371
Closed
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill in some of the Jiterp tables with the PackedSimd intrinsics so that both aliased and direct PackedSimd calls in the interpreter also benefit from the Jiterpreter. Also reenable the aliased opcodes now that they will share the jiterpreter optimizations.