{{ message }}
[9.0] libnethost no LTCG#113893
Merged
jkoritzinsky merged 3 commits intoApr 2, 2025
Merged
Conversation
Contributor
jeffschwMSFT
approved these changes
Mar 25, 2025
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
lgtm. please get a code review. we will take for consideration in 9.0.x
jeffschwMSFT
added
the
Servicing-consider
agocke
approved these changes
Mar 25, 2025
rbhanda
added
Servicing-approved
Contributor
|
Friendly reminder that code complete is on April 14th for the May Release. If you'd like to get this change included in that release, please get a Tactics approval and merge this PR before that date. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #113183
main PR #111805 (slimmed down for servicing)
Description
Ensure that libnethost isn't built with the
/LTCGflag, so users can use any version of MSVC to build their native .NET host using libnethost.Customer Impact
Users can't use the static libnethost unless they build their native host with the same compiler that we build .NET 9.0 with.
LTCG (link-time code-gen) requires the customer to use the exact same version of MSVC that we used if they want to build. We are reverting the flags to the old list (ensuring we don't specify LTCG for any object files in the libnethost static library). The only policy we have is that we can't put LTCG objects in any static library we ship
Regression
Yes, regressed in #102475
Testing
Locally validated that the libnethost static library doesn't have any files built with LTCG.
Risk
Low risk. Only affects users of libnethost.
Package authoring signed off?
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.