{{ message }}
Move generation of SuggestedBindingRedirects.targets to inner build#112379
Merged
ericstj merged 2 commits intoFeb 12, 2025
Conversation
These targets depend on the AssemblyVersion of the library which is specific to the inner-build of the library. Generate them in the inner-build.
ghost
added
the
Member
Author
|
We should backport this to servicing as well. |
This was referenced Feb 11, 2025
Open
Closed
ViktorHofer
reviewed
Feb 11, 2025
….Extensions.csproj
ViktorHofer
reviewed
Feb 11, 2025
ViktorHofer
reviewed
Feb 11, 2025
ViktorHofer
approved these changes
Feb 11, 2025
Member
Author
|
/backport to release/9.0-staging |
Contributor
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/13290017456 |
Member
Author
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/13290022508 |
Merged
4 tasks
Contributor
ericstj
added a commit
to ericstj/runtime
that referenced
this pull request
Feb 12, 2025
…otnet#112379) * Move generation of SuggestedBindingRedirects.targets to inner build These targets depend on the AssemblyVersion of the library which is specific to the inner-build of the library. Generate them in the inner-build. * Update src/libraries/System.Resources.Extensions/src/System.Resources.Extensions.csproj
Merged
4 tasks
ericstj
added a commit
that referenced
this pull request
Feb 19, 2025
…112379) (#112494) * Move generation of SuggestedBindingRedirects.targets to inner build These targets depend on the AssemblyVersion of the library which is specific to the inner-build of the library. Generate them in the inner-build. * Update src/libraries/System.Resources.Extensions/src/System.Resources.Extensions.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111892
These targets depend on the
AssemblyVersionof the library which is specific to the inner-build of the library. Generate them in the inner-build.I tried including in the package as part of the inner-build as well but we also have other infrastructure in the outer build that observes targets added to the package, but can only do so if they're added in the outer build.
runtime/eng/packaging.targets
Lines 229 to 230 in 91bbb32
I can't make that work so long as it runs in the outer build - since NuGet passes items out from inner-build only in a private item (
_PackageFiles). Probably I could refactor that to be part of the inner-build but it would be a larger change.