Fix `UnsafeAccessor` scenario for modopts/modreqs when comparing field sigs. by AaronRobinsonMSFT · Pull Request #111648 · dotnet/runtime · GitHub
Skip to content

Fix UnsafeAccessor scenario for modopts/modreqs when comparing field sigs.#111648

Merged
AaronRobinsonMSFT merged 3 commits into
dotnet:mainfrom
AaronRobinsonMSFT:runtime_111647
Jan 21, 2025
Merged

Fix UnsafeAccessor scenario for modopts/modreqs when comparing field sigs.#111648
AaronRobinsonMSFT merged 3 commits into
dotnet:mainfrom
AaronRobinsonMSFT:runtime_111647

Conversation

@AaronRobinsonMSFT

Copy link
Copy Markdown
Member

Consume custom modifiers and ByRef in RetType signature prior to comparing field signature.

Fixes #111647

prior to comparing field signature.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • src/coreclr/vm/prestub.cpp: Language not supported
  • src/coreclr/vm/siginfo.cpp: Language not supported
  • src/coreclr/vm/siginfo.hpp: Language not supported

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • src/coreclr/vm/prestub.cpp: Language not supported
  • src/coreclr/vm/siginfo.cpp: Language not supported
  • src/coreclr/vm/siginfo.hpp: Language not supported

@jkotas

jkotas commented Jan 21, 2025

Copy link
Copy Markdown
Member

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@AaronRobinsonMSFT

Copy link
Copy Markdown
Member Author

/backport to release/9.0-staging

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12890369826

@github-actions

Copy link
Copy Markdown
Contributor

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 242af17 into dotnet:main Jan 21, 2025
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the runtime_111647 branch January 21, 2025 18:39
AaronRobinsonMSFT added a commit to AaronRobinsonMSFT/runtime that referenced this pull request Jan 21, 2025
…d sigs. (dotnet#111648)

* Consume custom modifiers and ByRef in RetType signature
prior to comparing field signature.
AaronRobinsonMSFT added a commit that referenced this pull request Jan 24, 2025
…d sigs. (#111648) (#111675)

* Consume custom modifiers and ByRef in RetType signature
prior to comparing field signature.
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modopt/modreq parsing is busted in some cases for UnsafeAccessor scenarios

3 participants