[mono] Run runtime-llvm and runtime-ioslike on Mono LLVM PRs#111614
Conversation
matouskozak
requested review from
akoeplinger,
jkurdek,
lateralusX,
steveisok,
tannergooding and
vitek-karas
|
@tannergooding @lateralusX are there any other critical files that when modified, should trigger the Mono LLVM pipelines? |
|
We have the llvmonly-*, but they are only interesting on platforms running using llvmonly mode, so not sure the current runtime-llvm or runtime-ioslike pipelines will use anything using triggering llvmonly codegen. Any file under mini that would affect code generation could also be affecting LLVM code generation when changed that could in theory break LLVM AOT compilation/runtime, but if we are going to pick something additional, then maybe method-to-ir.c, decompose.c and mini.c. |
I don't think anything there runs in llvmonly mode. We used to have llvmonly on watchOS but that is no longer tested/supported.
Thank you, I'll add those. |
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12925542809 |
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/12926487412 |
…otnet#111614)" This reverts commit 41e2b8c.
5 participants
This PR enables running of
runtime-llvmandruntime-ioslikepipelines, by default, on PRs touching the following code:This is to ensure that we have proper coverage over Mono AOT-llvm when changes are made as we don't test these scenarios as part of the
runtimepipeline.Note: we need to enable
runtime-ioslikein addition toruntime-llvmbecause we are currently missing coverage for arm64 AOT Linux scenario (#90427).runtime-ioslikeprovides coverage over arm64-based TvOS devices which run AOT-llvm by default.Follow-up: Remove the setting in the AzDO pipeline settings to trigger on comments only