{{ message }}
Another attempt at fixing #99198#111255
Merged
Merged
Conversation
The problem was always `// Note: We don't set the IsUnboxingStub flag on template methods (all template lookups performed at runtime are performed with this flag not set`, I tried working around it in the original fix, but looks like I actually need the function pointer in dotnet#111178 (the tests are not failing but I have a local test that does). So trying an alternative approach that just deletes the weird code. It's possible this only had to be weird due to universal shared code.
ghost
added
the
Contributor
MichalStrehovsky
commented
Jan 9, 2025
| throw new MissingTemplateException(); | ||
| } | ||
|
|
||
| // We might have a mismatch between unboxing/non-unboxing variants so only remember it for static methods |
Member
Author
There was a problem hiding this comment.
This is my previous fix that now seems to be causing me problems.
Comment on lines
-757
to
-758
| // Note: We don't set the IsUnboxingStub flag on template methods (all template lookups performed at runtime are performed with this flag not set, | ||
| // since it can't always be conveniently computed for a concrete method before looking up its template) |
Member
Author
There was a problem hiding this comment.
This is the ancient .NET Native root of all evil.
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
davidwrighton
approved these changes
Jan 27, 2025
davidwrighton
left a comment
davidwrighton
left a comment
Member
There was a problem hiding this comment.
I managed to chase down the initial commit which added this logic to the type loader in our old source control system, and its not clear why it was needed. If it doesn't fail the tests now, I can't see a reason to keep this weird logic around.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was always
// Note: We don't set the IsUnboxingStub flag on template methods (all template lookups performed at runtime are performed with this flag not set, I tried working around it in the original fix, but looks like I actually need the function pointer in #111178 (the tests are not failing but I have a local test that does).So trying an alternative approach that just deletes the weird code. It's possible this only had to be weird due to universal shared code.