[wasm] Re-enable skiasharp WBT tests by radekdoulik · Pull Request #109232 · dotnet/runtime · GitHub
Skip to content

[wasm] Re-enable skiasharp WBT tests#109232

Merged
radekdoulik merged 9 commits into
dotnet:mainfrom
radekdoulik:pr-enable-skiasharp-tests-again
Nov 20, 2024
Merged

[wasm] Re-enable skiasharp WBT tests#109232
radekdoulik merged 9 commits into
dotnet:mainfrom
radekdoulik:pr-enable-skiasharp-tests-again

Conversation

@radekdoulik

@radekdoulik radekdoulik commented Oct 25, 2024

Copy link
Copy Markdown
Member

Resolves #103566

The included llvm bump (and emsdk, icu) fixes #109289 through dotnet/llvm-project#630

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 25, 2024
@radekdoulik radekdoulik added area-Infrastructure-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 25, 2024
@radekdoulik radekdoulik added this to the 10.0.0 milestone Oct 25, 2024
That would trigger build error, because we don't support that combination
anymore
Put NativeFileReference files after the runtime libs. This server as
a workaround of dotnet#109289
@radekdoulik radekdoulik force-pushed the pr-enable-skiasharp-tests-again branch from adbf98f to a7ab465 Compare November 18, 2024 21:35
Comment thread src/mono/wasm/Wasm.Build.Tests/NativeLibraryTests.cs
@radekdoulik

Copy link
Copy Markdown
Member Author

@radekdoulik radekdoulik merged commit 1c54b48 into dotnet:main Nov 20, 2024
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
* [wasm] Re-enable skiasharp WBT tests

* Disable Debug/AOT combination

That would trigger build error, because we don't support that combination
anymore

* Change order of native libs

Put NativeFileReference files after the runtime libs. This server as
a workaround of dotnet#109289

* Update llvm, emsdk and icu deps

* Revert "Change order of native libs"

This reverts commit e320fd6.
@radekdoulik

Copy link
Copy Markdown
Member Author

/backport to release/9.0-staging

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12352375711

@github-actions

Copy link
Copy Markdown
Contributor

radekdoulik added a commit to radekdoulik/runtime that referenced this pull request Dec 16, 2024
* [wasm] Re-enable skiasharp WBT tests

* Disable Debug/AOT combination

That would trigger build error, because we don't support that combination
anymore

* Change order of native libs

Put NativeFileReference files after the runtime libs. This server as
a workaround of dotnet#109289

* Update llvm, emsdk and icu deps

* Revert "Change order of native libs"

This reverts commit e320fd6.
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

4 participants