{{ message }}
Fix nativeaot outerloop#108916
Merged
Merged
Conversation
Member
Author
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
approved these changes
Oct 16, 2024
Member
Author
|
@carlossanlop this test was backported to both .NET 8 and .NET 9 and has been failing in outerloops ever since. We're about to ship .NET 9 GA with 16 out of 20 runtime-nativeaot-outerloop jobs consistently failing. I assume this means they are not part of our shipping criteria. Do you know how would I go about proposing adding runtime-nativeaot-outerloop to the shipping criteria? Cc @dotnet/ilc-contrib |
Member
Author
|
This doesn't fix all of outerloop because people were being productive writing more trim-unfriendly test code. I'll fix in a follow up in case we need to backport this PR. |
Member
Author
|
/backport to release/9.0 |
Contributor
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11399867413 |
Member
Author
|
/backport to release/8.0 |
Contributor
This was referenced Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typeof(RegionInfo).Assembly.GetTypeis too difficult to analyze for trimming. Native AOT outerloop runs crash with a NullReferenceException because the property is not reflection-visible.