[msbuild] Fix the PropertyListEditor task to correctly handle two input files. Fixes #24091. by rolfbjarne · Pull Request #24105 · dotnet/macios · GitHub
Skip to content

[msbuild] Fix the PropertyListEditor task to correctly handle two input files. Fixes #24091.#24105

Merged
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/issue-24091-propertylisteditor
Oct 27, 2025
Merged

[msbuild] Fix the PropertyListEditor task to correctly handle two input files. Fixes #24091.#24105
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/issue-24091-propertylisteditor

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Oct 27, 2025

Copy link
Copy Markdown
Member

Fix the PropertyListEditor task to not only check for null input, but also
empty empty - this fixes an regression where we changed the default property
value for the task inputs from null to an empty string, and then any null
checks later on would fail.

Fixes #24091.

@rolfbjarne
[msbuild] Fix the PropertyListEditor task to correclty handle two inp…
dc05811 
…ut files. Fixes #24091.

Fix the PropertyListEditor task to not only check for null input, but also
empty empty - this fixes an regression where we changed the default property
value for the task inputs from null to an empty string, and then any null
checks later on would fail.

Fixes #24091.
@rolfbjarne rolfbjarne changed the title [msbuild] Fix the PropertyListEditor task to correclty handle two input files. Fixes #24091. [msbuild] Fix the PropertyListEditor task to correctly handle two input files. Fixes #24091. Oct 27, 2025
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

✅ [PR Build #dc05811] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

✅ [CI Build #dc05811] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #dc05811] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #dc05811] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #dc05811] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #dc05811] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #dc05811] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@rolfbjarne rolfbjarne enabled auto-merge (squash) October 27, 2025 18:27
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

@rolfbjarne rolfbjarne merged commit ef864de into main Oct 27, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes
@mauroa mauroa mauroa approved these changes
@emaf emaf emaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PropertyListEditor.Entry defaulted to string.Empty

5 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @mauroa @emaf