[runtime] Adopt safer native compiler flags: Wignored-qualifiers by rolfbjarne · Pull Request #24068 · dotnet/macios · GitHub
Skip to content

[runtime] Adopt safer native compiler flags: Wignored-qualifiers#24068

Merged
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/safer-flags-Wignored-qualifiers
Oct 23, 2025
Merged

[runtime] Adopt safer native compiler flags: Wignored-qualifiers#24068
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/safer-flags-Wignored-qualifiers

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

Example warning:

macios/runtime/xamarin/runtime.h:232:14: error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
  232 | const char * const      xamarin_get_original_working_directory_path ();

References:

Contributes towards #23023.

Example warning:

```
macios/runtime/xamarin/runtime.h:232:14: error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
  232 | const char * const      xamarin_get_original_working_directory_path ();
```

References:

* https://developer.apple.com/documentation/xcode/enabling-enhanced-security-for-your-app
* https://releases.llvm.org/8.0.0/tools/clang/docs/ReleaseNotes.html#major-new-features (for -ftrivial-auto-var-init=zero)

Contributes towards #23023.
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #289a8a4] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 289a8a41ab03081a26aec64f0cc29134c6ee8844 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 289a8a41ab03081a26aec64f0cc29134c6ee8844 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

@rolfbjarne rolfbjarne merged commit 53f7714 into main Oct 23, 2025
45 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/safer-flags-Wignored-qualifiers branch October 23, 2025 06:17
@rolfbjarne rolfbjarne linked an issue Oct 28, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Look into new security features with Xcode 26

3 participants