[Foundation] Improve cookie storage a bit in NSUrlSessionHandler. Fixes #23950. by rolfbjarne · Pull Request #24058 · dotnet/macios · GitHub
Skip to content

[Foundation] Improve cookie storage a bit in NSUrlSessionHandler. Fixes #23950.#24058

Merged
rolfbjarne merged 2 commits into
mainfrom
dev/rolf/issue-23950-usecookies
Oct 22, 2025
Merged

[Foundation] Improve cookie storage a bit in NSUrlSessionHandler. Fixes #23950.#24058
rolfbjarne merged 2 commits into
mainfrom
dev/rolf/issue-23950-usecookies

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Oct 21, 2025

Copy link
Copy Markdown
Member
  • Add xml docs for NSUrlSessionHandler.UseCookies.
  • Allow cookies for ephemeral sessions (but it can't be re-enabled once disabled).
  • Add more tests for ephemeral sessions.

Fixes #23950.

@rolfbjarne
[Foundation] Improve cookie storage a bit in NSUrlSessionHandler. Fixes
c4aa88c 
#23950.

* Add xml docs for NSUrlSessionHandler.UseCookies.
* Allow cookies for ephemeral sessions (but it can't be re-enabled once disabled).
* Add more tests for ephemeral sessions.

Fixes #23950.
@rolfbjarne rolfbjarne enabled auto-merge (squash) October 21, 2025 11:22
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 21, 2025

Copy link
Copy Markdown
Collaborator

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 21, 2025

Copy link
Copy Markdown
Collaborator

✅ [PR Build #fed3f31] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: fed3f3165e628b8cfcd255d182997e80a3847a33 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 21, 2025

Copy link
Copy Markdown
Collaborator

✅ [CI Build #fed3f31] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: fed3f3165e628b8cfcd255d182997e80a3847a33 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 21, 2025

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: fed3f3165e628b8cfcd255d182997e80a3847a33 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 21, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #fed3f31] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: fed3f3165e628b8cfcd255d182997e80a3847a33 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 21, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #fed3f31] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: fed3f3165e628b8cfcd255d182997e80a3847a33 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 21, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #fed3f31] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: fed3f3165e628b8cfcd255d182997e80a3847a33 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 21, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #fed3f31] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: fed3f3165e628b8cfcd255d182997e80a3847a33 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 21, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #fed3f31] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: fed3f3165e628b8cfcd255d182997e80a3847a33 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 22, 2025

Copy link
Copy Markdown
Collaborator

@rolfbjarne rolfbjarne merged commit 7b961c6 into main Oct 22, 2025
45 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/issue-23950-usecookies branch October 22, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes
@mandel-macaque mandel-macaque Awaiting requested review from mandel-macaque

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lifecycle of NSUrlSessionHandler CookieContainer vs the underlying NsUrlSession NSHttpCookieStorage.SharedStorage

3 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto