[NetworkExtension] Fix nullability for NETunnelProvider.HandleAppMessage. Fixes #16789. by rolfbjarne · Pull Request #23948 · dotnet/macios · GitHub
Skip to content

[NetworkExtension] Fix nullability for NETunnelProvider.HandleAppMessage. Fixes #16789.#23948

Merged
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/issue-16789-netunnelprovider-handleappmessage
Oct 8, 2025
Merged

[NetworkExtension] Fix nullability for NETunnelProvider.HandleAppMessage. Fixes #16789.#23948
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/issue-16789-netunnelprovider-handleappmessage

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Oct 7, 2025

Copy link
Copy Markdown
Member

And since it's a breaking change, only in XAMCORE_5_0.

Fixes #16789.

@rolfbjarne
[NetworkExtension] Fix nullability for NETunnelProvider.HandleAppMess…
c21d098 
…age. Fixes #16789.

And since it's a breaking change, only in XAMCORE_5_0.

Fixes #16789.
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

✅ [PR Build #c21d098] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: c21d0980caa131a219febf291c25540eab587df1 [PR build]

@rolfbjarne rolfbjarne enabled auto-merge (squash) October 7, 2025 17:23
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c21d0980caa131a219febf291c25540eab587df1 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

✅ [CI Build #c21d098] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: c21d0980caa131a219febf291c25540eab587df1 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #c21d098] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: c21d0980caa131a219febf291c25540eab587df1 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #c21d098] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: c21d0980caa131a219febf291c25540eab587df1 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #c21d098] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: c21d0980caa131a219febf291c25540eab587df1 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #c21d098] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: c21d0980caa131a219febf291c25540eab587df1 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

💻 [CI Build #c21d098] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: c21d0980caa131a219febf291c25540eab587df1 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

@rolfbjarne rolfbjarne merged commit e79eff0 into main Oct 8, 2025
45 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/issue-16789-netunnelprovider-handleappmessage branch October 8, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NETunnelProvider.HandleAppMessage() method signature does not match underlying Obj-C Implementation

3 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto