Preserve SRTP code generation in older language versions by T-Gro · Pull Request #20773 · dotnet/fsharp · GitHub
Skip to content

Preserve SRTP code generation in older language versions - #20773

Merged
T-Gro merged 3 commits into
mainfrom
t-gro-legacy-srtp-compatibility
Oct 13, 2026
Merged

Preserve SRTP code generation in older language versions#20773
T-Gro merged 3 commits into
mainfrom
t-gro-legacy-srtp-compatibility

Conversation

@T-Gro

@T-Gro T-Gro commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Calls to overloaded SRTP operators failed with FS0001 in F# 10.0 and 11.0 after #20717.

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

T-Gro and others added 2 commits October 12, 2026 11:22
@T-Gro
Preserve legacy SRTP codegen when extensions are disabled
58dc23c 
Keep the original untraced codegen solver when ExtensionConstraintSolutions is disabled. Retain transactional rollback for feature-enabled probes. Check the existing issue 15987 runtime assertions in default, preview, and 10.0 language modes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit df9defe)
@T-Gro
Cover F# 11.0 SRTP compatibility
02819e2 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@T-Gro
T-Gro requested a review from a team as a code owner October 12, 2026 10:01
@github-actions

github-actions Bot commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@T-Gro
Link the SRTP compatibility release note
e4c8c88 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@T-Gro
T-Gro requested a review from abonie October 12, 2026 10:06
@github-project-automation github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling Oct 12, 2026
@T-Gro T-Gro mentioned this pull request Oct 12, 2026
Merged
2 of 3 tasks
@T-Gro
T-Gro merged commit 8a83ffd into main Oct 13, 2026
55 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in F# Compiler and Tooling Oct 13, 2026
@T-Gro

T-Gro commented Oct 13, 2026

Copy link
Copy Markdown
Member Author

/backport to release/11.0.1xx-rc2

@github-actions

github-actions Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Started backporting to release/11.0.1xx-rc2 (link to workflow run)

@github-actions

github-actions Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

This was referenced Oct 13, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonie abonie abonie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@T-Gro @abonie