{{ message }}
Repository navigation
Fix fsi auto-loading of script file inside NuGet package. - #18177
Merged
Merged
Conversation
Contributor
Member
|
This is a good fix. @teo-tsirpanis We do have some existing tests which use "nuget: .." dependency loading and validating some cases. Do you have a package where the fixed behavior happens? |
Contributor
|
I will take a look at the test failures. |
KevinRansom
suggested changes
Jan 3, 2025
KevinRansom
left a comment
KevinRansom
left a comment
Contributor
There was a problem hiding this comment.
The test failures are signficant.
This reverts commit 1925e91.
teo-tsirpanis
force-pushed
the
fsi-nuget-script-fix
branch
from
January 3, 2025 08:30
adfb89c to
ad4edca
Compare
Contributor
Author
|
@KevinRansom CI is now green. @T-Gro I will make use of this for the next version of the Farkle library, but it is not yet published. I don't know any other package that does this. |
Member
T-Gro
approved these changes
Jan 13, 2025
T-Gro
enabled auto-merge (squash)
January 13, 2025 13:02
KevinRansom
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the project file generated by
FSharp.DependencyManager.NuGet, we've been referencing aPackageRootitem metadata that does not exist (line 136), causing inability to find the script file,Fixes #18176 as validated locally by patching the
FSharp.DependencyManager.Nuget.dllof a .NET SDK installation.Checklist
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated: