Migrate VisualFSharp tests to Xunit by psfinaki · Pull Request #17751 · dotnet/fsharp · GitHub
Skip to content

Migrate VisualFSharp tests to Xunit #17751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psfinaki merged 12 commits into from
Sep 23, 2024
Merged

Migrate VisualFSharp tests to Xunit #17751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
533511d
Migrate last Nunit tests to Xunit
psfinaki Sep 16, 2024
d22973d
up
psfinaki Sep 17, 2024
ff9ba24
up
psfinaki Sep 17, 2024
c3114cb
up
psfinaki Sep 17, 2024
03ac691
Update TestLib.LanguageService.fs
psfinaki Sep 17, 2024
715ff7c
up
psfinaki Sep 18, 2024
ba5108b
up
psfinaki Sep 18, 2024
a70d897
Merge branch 'main' into tests-10
KevinRansom Sep 18, 2024
ac7b0fb
up
psfinaki Sep 19, 2024
1e4d34a
Remove unused tests
psfinaki Sep 20, 2024
49ed74b
one more
psfinaki Sep 20, 2024
5aec65f
up
psfinaki Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions TESTGUIDE.md
View file
Open in desktop
7 changes: 0 additions & 7 deletions vsintegration/tests/UnitTests/AssemblyResolver.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
namespace Microsoft.VisualStudio.FSharp

open NUnit.Framework
open System
open System.IO
open System.Reflection
Expand Down Expand Up @@ -46,9 +45,3 @@ module AssemblyResolver =
match found() with
| None -> Unchecked.defaultof<Assembly>
| Some name -> Assembly.Load(name) )

[<SetUpFixture>]
type public AssemblyResolverTestFixture () =

[<OneTimeSetUp>]
Comment thread
psfinaki marked this conversation as resolved.
member public _.Init () = AssemblyResolver.addResolver ()
9 changes: 3 additions & 6 deletions vsintegration/tests/UnitTests/DocCommentIdParserTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
// Copyright (c) Microsoft Corporation. All Rights Reserved. See License.txt in the project root for license information.
[<NUnit.Framework.TestFixture>]

module Tests.ServiceAnalysis.DocCommentIdParser

open NUnit.Framework
open Xunit
open Microsoft.VisualStudio.FSharp.Editor




[<Test>]
[<Fact>]
let ``Test DocCommentId parser``() =
let testData = dict [
"T:N.X.Nested", DocCommentId.Type ["N"; "X"; "Nested"];
Expand Down
1,262 changes: 564 additions & 698 deletions vsintegration/tests/UnitTests/LegacyLanguageService/Tests.LanguageService.Completion.fs
View file
Open in desktop

Large diffs are not rendered by default.

200 changes: 77 additions & 123 deletions vsintegration/tests/UnitTests/LegacyLanguageService/Tests.LanguageService.ErrorList.fs
View file
Open in desktop

Large diffs are not rendered by default.

48 changes: 16 additions & 32 deletions vsintegration/tests/UnitTests/LegacyLanguageService/Tests.LanguageService.ErrorRecovery.fs
View file
Open in desktop
Loading