{{ message }}
Open
Conversation
…mpl_DX11 ported from Cpp file. WARNING: never compiled inside Silk.NET solution
Author
Author
|
I have pushed my prototype code all in one. My apologize for the long files! As a recap:
|
Member
|
No worries. Is this ready for review? (it's still marked as draft :P) |
Author
|
Not yet, I've set aside my compilation issues and improved the code to support .NET 6.0 features (instead of the .NET 9.0 I created my prototype on). I've also made a minimal sample that works which I'll push soon afterwards. |
…IntPtr conversion). csharp12 is required to pass readonly ref to dx wrapper. Still wasn't able to build inside the solution
Demo is heavily inspired by the DX11 Tutorial 1.2 - HelloQuad. I tried to reduce the sample to a minimal state to show off ImGui.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This PR introduces initial support for ImGui with DirectX11 in Silk.NET. It includes:
Related issues, Discord discussions, or proposals
Current progress
/src/Lab/Experiments/ImGui_DX11/ImGui_Impl_DX11.cs(C++ port) and the associatedImGuiDX11Controller.csFurther Comments
The changes should not introduce any breaking API or behavioral changes: they will extend the functionality of Silk.NET.
Tested on
Remarks
This is actually my first PR to such a large open-source repo. Any help, constructive criticism, remarks, suggestions, improvements and feedback are greatly appreciated!