{{ message }}
Repository navigation
Conversation
samafarc
commented
Oct 19, 2026
Contributor
Signed-off-by: Samar Farooqi <samafarc@amazon.com>
…lter tests Signed-off-by: Samar Farooqi <samafarc@amazon.com>
eerxuan
reviewed
Oct 21, 2026
eerxuan
left a comment
Collaborator
There was a problem hiding this comment.
Summary
Turns two crash-on-unsupported patterns into assertion failures: the $out tests index
into listCollections after a failed $out, and the planCacheSetFilter tests subscript
indexFilterSet. I checked the $out change with a stubbed executor that makes $out
fail: main raises IndexError, this branch raises an AssertionError carrying the
engine's error. CI is green on both mongo targets. One file with the same $out pattern
is not covered (item 1).
Critical Issues
- [Required]
test_out_write_behavior.py:100has the same crash and is not changed.
test_out_database_name_acceptancecalls$out, discards the result, then reads
cast(dict, result)["cursor"]["firstBatch"][0]fromlistCollections. An engine that
rejects$outstill gets anIndexErrorthere. It is the third file with this pattern
(grep 'firstBatch"\]\[0\]'instages/out/finds exactly these three). Please apply
the same fix, or say why this file is excluded.
Positive Feedback
- The root cause is correctly identified: the crash hides the engine's actual error.
- The scope is small, and the description says what was run (57 and 24 passed on MongoDB 8.2.4).
.get()forindexFilterSetis correct for the assertion. A missing field yieldsNone,
whichEq(True)rejects, so no test can switch from failing to passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
