{{ message }}
Repository navigation
Conversation
Signed-off-by: PatersonProjects <keldonhoff@gmail.com> Signed-off-by: afanankhan <afanankhan@microsoft.com>
Comprehensive compat-functional tests covering type coercion, boundary values, nested paths, command paths (update, findAndModify), multi-doc updates, upsert, composition, and error cases. 3 known divergences tracked with engine_xfail markers: - $[] on empty array: nModified=1 instead of 0 (ADO #5329571) - $[] on non-array field: error code 28 instead of 2 (ADO #5329572) - $ positional nested array: matches wrong element (ADO #5329573) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: afanankhan <afanankhan@microsoft.com>
Comprehensive compat-functional tests covering: - $max: type comparison, cross-type ordering, NaN, dates, missing fields - $pop: first/last, empty array, nested paths, invalid values - $pull: exact match, conditional ($gte, $in), document match, nested - $[<identifier>]: basic filters, scalar arrays, multi, findAndModify 2 divergences tracked with engine_xfail markers: - $pop on non-array: error code 2 instead of 14 (TypeMismatch) - $[<identifier>] invalid identifier: accepts instead of rejecting All tests stable across 5 serial iterations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: afanankhan <afanankhan@microsoft.com>
This reverts commit 851e883. Signed-off-by: afanankhan <afanankhan@microsoft.com>
Signed-off-by: afanankhan <afanankhan@microsoft.com>
Signed-off-by: afanankhan <afanankhan@microsoft.com>
afn7081
force-pushed
the
users/afanankhan/maxpoppulltests
branch
from
June 4, 2026 13:20
d946778 to
77c6f8e
Compare
eerxuan
reviewed
Jun 5, 2026
eerxuan
left a comment
Collaborator
There was a problem hiding this comment.
Please claim the tracking issue before raise PR, we are seeing overlapping effort across PRs. Also can you start with issues with "Second pass"? Amazon team is working through First pass features. We planned 48 features in this sprint, will claim the issues shortly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add behavior tests for $max, $pop,$pull, $ []