[Issue #494] New config option skipLink for accessibility by dmed256 · Pull Request #495 · docsifyjs/docsify · GitHub
Skip to content

[Issue #494] New config option skipLink for accessibility#495

Closed
dmed256 wants to merge 2 commits into
docsifyjs:masterfrom
dmed256:master
Closed

[Issue #494] New config option skipLink for accessibility#495
dmed256 wants to merge 2 commits into
docsifyjs:masterfrom
dmed256:master

Conversation

@dmed256

@dmed256 dmed256 commented May 19, 2018

Copy link
Copy Markdown

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

@dmed256 dmed256 changed the title [Issue #494] New config option addSkipLink for accessibility [Issue #494] New config option skipLink for accessibility May 19, 2018
@dmed256

dmed256 commented May 20, 2018

Copy link
Copy Markdown
Author

Comment thread src/core/render/index.js
dom.before(navAppendToTarget, navEl)
}

if (config.skipLink

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried adding this to <body></body> but <nav> was always added first

@QingWei-Li

Copy link
Copy Markdown
Member

I think this should be a plugin.

@dmed256

dmed256 commented May 21, 2018

Copy link
Copy Markdown
Author

Ok, I'll split it as a plugin
Should it be outside of docsify as well?

@QingWei-Li

Copy link
Copy Markdown
Member

Yes.

@trusktr

trusktr commented Jun 21, 2020

Copy link
Copy Markdown
Member

I think accessibility should be in core, right? Isn't what the site "looks" like important, not just for people with eyes? @jhildenbiddle wdyt?

@jhildenbiddle

jhildenbiddle commented Jun 21, 2020

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add option to generate skip link for screen reader users

4 participants