{{ message }}
Fix: Accessibility roles and aria labels#2304
Merged
Merged
Conversation
Koooooo-7
approved these changes
Nov 16, 2023
trusktr
approved these changes
Nov 29, 2023
trusktr
left a comment
trusktr
left a comment
Member
There was a problem hiding this comment.
The changes look good for non-ecosystem-breaking changes. Are there any other elements that could possibly need aria labels?
Member
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves site accessibility by assigning proper roles and aria attributes to elements by implementing all non-breaking recommendations from #2295.
Note: You may have to unmute the videos below to hear VoiceOver audio.
Before
2295-before.mp4
After
2295-after.mp4
Related issue, if any:
#2295
What kind of change does this PR introduce?
Accessibility
Fix
Feature
Does this PR introduce a breaking change?
No
Tested in the following browsers: